Update: Improve report location for no-unneeded-ternary (refs #12334) #13456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Other, please explain:
refs #12334
This PR changes reported location in the
no-unneeded-ternary
rule.This change can produce more warnings in certain cases with
eslint-disable-*
comments.What changes did you make? (Give an overview)
Reported location will be now the full location or the conditional expression, instead of the start loc of its consequent.
Before this change:
After this change:
I believe it's more correct to report conditional expression's loc instead of consequent's loc, for two reasons:
!!b
).b ? true : false
case, this expression isn't considered invalid by this rule only because of its consequent. If the alternate wasn't a boolean literal as well, this expression would be valid by this rule.Is there anything you'd like reviewers to focus on?
This change can produce new warnings, in cases like the following:
user would have to change the line of the disable comment, to e.g.,: