Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix wording in configuring.md #13469

Merged
merged 2 commits into from Jul 9, 2020
Merged

Conversation

piperchester
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Micro wording fix in a doc.

Is there anything you'd like reviewers to focus on?

Nope!

@jsf-clabot
Copy link

jsf-clabot commented Jul 7, 2020

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jul 7, 2020
@piperchester piperchester reopened this Jul 7, 2020
@piperchester piperchester changed the title Fix wording in configuring.md Docs: fix wording in configuring.md Jul 7, 2020
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull requests. There is, indeed, a plural form mismatch to fix.

It looks like you haven't yet signed the CLA. Before we can consider your pull request, please sign the CLA by clicking here.

Thanks!

docs/user-guide/configuring.md Outdated Show resolved Hide resolved
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
@piperchester
Copy link
Contributor Author

Thanks for the pull requests. There is, indeed, a plural form mismatch to fix.

It looks like you haven't yet signed the CLA. Before we can consider your pull request, please sign the CLA by clicking here.

Thanks!

Thanks! Done :-)

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit e951457 into eslint:master Jul 9, 2020
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 6, 2021
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants