Update: require meta for fixable rules in RuleTester (refs #13349)
#13489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
added
core
|
This is now ready for review. As agreed in #13349, this change should have an announcement. Regarding the announcement, I'm not sure should it be published before this change gets released, or in the release blog post. |
kaicataldo
approved these changes
Jul 31, 2020
|
Thanks for contributing! |
moeriki
added a commit
to moeriki/eslint
that referenced
this pull request
Aug 9, 2020
…gnore-default-values * upstream/master: (66 commits) Sponsors: Sync README with website Sponsors: Sync README with website Sponsors: Sync README with website Sponsors: Sync README with website Sponsors: Sync README with website Chore: remove leche (fixes eslint#13287) (eslint#13533) Sponsors: Sync README with website Sponsors: Sync README with website 7.6.0 Build: changelog update for 7.6.0 Update: require `meta` for fixable rules in RuleTester (refs eslint#13349) (eslint#13489) Docs: fix broken links in developer guide (eslint#13518) Fix: Do not output `undefined` as line and column when it's unavailable (eslint#13519) Sponsors: Sync README with website Sponsors: Sync README with website Fix: Update the chatroom link to go directly to help channel (eslint#13536) Sponsors: Sync README with website Update: Change no-duplicate-case to comparing tokens (fixes eslint#13485) (eslint#13494) Docs: add ECMAScript 2020 to README (eslint#13510) 7.5.0 ...
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Add something to the core
refs #13349, fixes step 2 from this comment.
This PR updates RuleTester to require
metaproperty in fixable rules.What changes did you make? (Give an overview)
An
invalidtest case, where the rule being tested has fixed the given code, will now fail if the rule doesn't havemetaproperty.Is there anything you'd like reviewers to focus on?
RuleTesterstill doesn't check formeta.fixable, because linter already throws an error if the rule that provided a fix does havemetabut doesn't havemeta.fixable.This change doesn't affect legacy-format rules (functions). They will be still allowed to make fixes. I guess that was decided?