Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: clarify behavior if meta.fixable is omitted (refs #13349) #13493

Merged
merged 1 commit into from Jul 18, 2020

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update

refs #13349

Updates sections about meta.fixable in the working-with-rules document.

What changes did you make? (Give an overview)

Clarifies that ESLint throws an error if a fixable rule doesn't have meta.fixable property, instead of just not applying fixes.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added the documentation Relates to ESLint's documentation label Jul 14, 2020
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic changed the title Docs: clarify behavior if meta.fixable is ommited (refs #13349) Docs: clarify behavior if meta.fixable is omitted (refs #13349) Jul 15, 2020
@mdjermanovic
Copy link
Member Author

Just fixed a typo in the commit message and PR title.

@kaicataldo kaicataldo merged commit 885a145 into master Jul 18, 2020
@kaicataldo kaicataldo deleted the docs-meta-fixable branch July 18, 2020 00:46
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 15, 2021
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants