New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Change no-duplicate-case to comparing tokens (fixes #13485) #13494
Update: Change no-duplicate-case to comparing tokens (fixes #13485) #13494
Conversation
Change `no-duplicate-case` rule to change from detecting duplicates comparing text to detecting duplicates comparing tokens, like `no-dupe-else-if` rule.
Thanks for the PR! I initially added "do not merge label" just to verify if this change has to be in a major release. We're of an opinion that the current version of this rule fails to report some duplicates (those covered by this change), and that it's technically a bug. Thus, this change can be treated as a semver-minor bug fix, so I'm removing the label now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for contributing! |
…gnore-default-values * upstream/master: (66 commits) Sponsors: Sync README with website Sponsors: Sync README with website Sponsors: Sync README with website Sponsors: Sync README with website Sponsors: Sync README with website Chore: remove leche (fixes eslint#13287) (eslint#13533) Sponsors: Sync README with website Sponsors: Sync README with website 7.6.0 Build: changelog update for 7.6.0 Update: require `meta` for fixable rules in RuleTester (refs eslint#13349) (eslint#13489) Docs: fix broken links in developer guide (eslint#13518) Fix: Do not output `undefined` as line and column when it's unavailable (eslint#13519) Sponsors: Sync README with website Sponsors: Sync README with website Fix: Update the chatroom link to go directly to help channel (eslint#13536) Sponsors: Sync README with website Update: Change no-duplicate-case to comparing tokens (fixes eslint#13485) (eslint#13494) Docs: add ECMAScript 2020 to README (eslint#13510) 7.5.0 ...
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
fixes #13485
What changes did you make? (Give an overview)
This PR changes
no-duplicate-case
rule to change from detecting duplicates comparing text to detecting duplicates comparing tokens, likeno-dupe-else-if
rule.Is there anything you'd like reviewers to focus on?