Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Change no-duplicate-case to comparing tokens (fixes #13485) #13494

Merged
merged 1 commit into from Jul 22, 2020
Merged

Update: Change no-duplicate-case to comparing tokens (fixes #13485) #13494

merged 1 commit into from Jul 22, 2020

Conversation

ota-meshi
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #13485

What changes did you make? (Give an overview)

This PR changes no-duplicate-case rule to change from detecting duplicates comparing text to detecting duplicates comparing tokens, like no-dupe-else-if rule.

Is there anything you'd like reviewers to focus on?

Change `no-duplicate-case` rule to change from detecting duplicates comparing text to detecting duplicates comparing tokens, like `no-dupe-else-if` rule.
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jul 16, 2020
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion do not merge This pull request should not be merged yet enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Jul 16, 2020
@mdjermanovic
Copy link
Member

Thanks for the PR!

I initially added "do not merge label" just to verify if this change has to be in a major release.

We're of an opinion that the current version of this rule fails to report some duplicates (those covered by this change), and that it's technically a bug.

Thus, this change can be treated as a semver-minor bug fix, so I'm removing the label now.

@mdjermanovic mdjermanovic removed the do not merge This pull request should not be merged yet label Jul 16, 2020
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdjermanovic mdjermanovic merged commit e71e298 into eslint:master Jul 22, 2020
@mdjermanovic
Copy link
Member

Thanks for contributing!

@ota-meshi ota-meshi deleted the chagne-no-duplicate-case branch July 22, 2020 01:01
moeriki added a commit to moeriki/eslint that referenced this pull request Aug 9, 2020
…gnore-default-values

* upstream/master: (66 commits)
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Chore: remove leche (fixes eslint#13287) (eslint#13533)
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  7.6.0
  Build: changelog update for 7.6.0
  Update: require `meta` for fixable rules in RuleTester (refs eslint#13349) (eslint#13489)
  Docs: fix broken links in developer guide (eslint#13518)
  Fix: Do not output `undefined` as line and column when it's unavailable (eslint#13519)
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Fix: Update the chatroom link to go directly to help channel (eslint#13536)
  Sponsors: Sync README with website
  Update: Change no-duplicate-case to comparing tokens (fixes eslint#13485) (eslint#13494)
  Docs: add ECMAScript 2020 to README (eslint#13510)
  7.5.0
  ...
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 19, 2021
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change no-duplicate-case rule to comparing tokens
5 participants