Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade:lodash@4.17.19 #13499

Merged
merged 1 commit into from Jul 18, 2020
Merged

Upgrade:lodash@4.17.19 #13499

merged 1 commit into from Jul 18, 2020

Conversation

Crow-EH
Copy link
Contributor

@Crow-EH Crow-EH commented Jul 17, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Upgrade Lodash

What changes did you make? (Give an overview)

Upgraded our direct dependency to Lodash to 4.17.19.
There's a related NPM advisory: https://www.npmjs.com/advisories/1523

Is there anything you'd like reviewers to focus on?

If you decide to approve this PR, you can either merge it directly, or wait for two of our dependencies to upgrade Lodash too:

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jul 17, 2020
@saq194
Copy link

saq194 commented Jul 17, 2020

dd

@mdjermanovic mdjermanovic added upgrade This change is related to a dependency upgrade and removed triage An ESLint team member will look at this issue soon labels Jul 17, 2020
@mdjermanovic
Copy link
Member

Note to merger: we should probably add a space between Upgrade: and lodash@4.17.19 in the commit message.

mdjermanovic
mdjermanovic approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit 6ed9e8e into eslint:master Jul 18, 2020
@kaicataldo
Copy link
Member

Thanks for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 15, 2021
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion upgrade This change is related to a dependency upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Crow-EH @saq194 @mdjermanovic @kaicataldo