Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove leche (fixes #13287) #13533

Merged
merged 5 commits into from Aug 2, 2020
Merged

Chore: remove leche (fixes #13287) #13533

merged 5 commits into from Aug 2, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 27, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

#13287

What changes did you make? (Give an overview)

  • replaced usages of leche.withData with Array.forEach for tests
  • replaced leche stubbed fs declarations

Is there anything you'd like reviewers to focus on?

  • hawk eyes for identifying any potential edge cases or bugs this may cause
  • any test cases that * should * be added?

@jsf-clabot
Copy link

jsf-clabot commented Jul 27, 2020

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jul 27, 2020
@aladdin-add aladdin-add changed the title Feature/13287/remove leche Chore: remove leche Jul 30, 2020
@aladdin-add aladdin-add changed the title Chore: remove leche Chore: remove leche (fixes #13287) Jul 30, 2020
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!~

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sign the CLA.

Thanks

@kaicataldo kaicataldo added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Aug 1, 2020
@aladdin-add aladdin-add merged commit 9124a15 into eslint:master Aug 2, 2020
@aladdin-add
Copy link
Member

merged, thanks for contributing!

moeriki added a commit to moeriki/eslint that referenced this pull request Aug 9, 2020
…gnore-default-values

* upstream/master: (66 commits)
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Chore: remove leche (fixes eslint#13287) (eslint#13533)
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  7.6.0
  Build: changelog update for 7.6.0
  Update: require `meta` for fixable rules in RuleTester (refs eslint#13349) (eslint#13489)
  Docs: fix broken links in developer guide (eslint#13518)
  Fix: Do not output `undefined` as line and column when it's unavailable (eslint#13519)
  Sponsors: Sync README with website
  Sponsors: Sync README with website
  Fix: Update the chatroom link to go directly to help channel (eslint#13536)
  Sponsors: Sync README with website
  Update: Change no-duplicate-case to comparing tokens (fixes eslint#13485) (eslint#13494)
  Docs: add ECMAScript 2020 to README (eslint#13510)
  7.5.0
  ...
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 30, 2021
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants