Fix: indent for async arrow functions (fixes #13497) #13544
Merged
+138
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
anikethsaha
added
accepted
mdjermanovic
added
bug
mdjermanovic
reviewed
Aug 2, 2020
kaicataldo
suggested changes
Aug 3, 2020
kaicataldo
suggested changes
Aug 4, 2020
mdjermanovic
reviewed
Aug 6, 2020
mdjermanovic
reviewed
Aug 6, 2020
mdjermanovic
reviewed
Aug 8, 2020
mdjermanovic
reviewed
Aug 9, 2020
aladdin-add
reviewed
Aug 12, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
fixes #13497
Indent for async arrow function was not working as the first token in the async arrow function node is the
asyncnot the opening paren. So the condition here would not be truthy.So I added one more check for simply checking the type as
Identifierand value asasyncIs there anything you'd like reviewers to focus on?
None