Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: support numeric-separator in no-loss-of-precision (refs #13568) #13574

Merged
merged 4 commits into from Aug 29, 2020
Merged

Update: support numeric-separator in no-loss-of-precision (refs #13568) #13574

merged 4 commits into from Aug 29, 2020

Conversation

anikethsaha
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added support for numeric separators in no-loss-of-precision

Is there anything you'd like reviewers to focus on?

ref #13568

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 16, 2020
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion do not merge This pull request should not be merged yet new syntax This issue is related to new syntax that has reached stage 4 rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Aug 17, 2020
@mdjermanovic
Copy link
Member

Added "do not merge" as a reminder to update package.json before merging.

This was referenced Aug 17, 2020
Closed
Merged
mdjermanovic
mdjermanovic requested changes Aug 19, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small jsdoc suggestion

lib/rules/no-loss-of-precision.js Outdated Show resolved Hide resolved
mdjermanovic
mdjermanovic approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

kaicataldo
kaicataldo approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic mentioned this pull request Aug 22, 2020
Merged
1 task
@mdjermanovic
Copy link
Member

#13609 has been merged, so this can be rebased now, and then we could remove "do not merge" label :)

@anikethsaha anikethsaha force-pushed the numeric-separate-no-loss-of-precision branch from 44d109e to 648f9b8 Compare August 26, 2020 13:02
@anikethsaha anikethsaha removed the do not merge This pull request should not be merged yet label Aug 26, 2020
@anikethsaha @mdjermanovic
Chore: update lib/rules/no-loss-of-precision.js
7777d72 
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
mdjermanovic
mdjermanovic approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

btmills
btmills approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work @anikethsaha!

@btmills btmills mentioned this pull request Aug 28, 2020
Merged
1 task
kaicataldo
kaicataldo approved these changes Aug 29, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@kaicataldo kaicataldo merged commit 3439fea into eslint:master Aug 29, 2020
@mdjermanovic mdjermanovic mentioned this pull request Sep 5, 2020
Closed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 18, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@btmills btmills btmills approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion new syntax This issue is related to new syntax that has reached stage 4 rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anikethsaha @mdjermanovic @btmills @kaicataldo