Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add common 3rd party parsers to issue template #13596

Merged
merged 1 commit into from Aug 22, 2020

Conversation

kaicataldo
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Chore

What changes did you make? (Give an overview)

This PR updates the issue template to list the two most commonly used 3rd party parsers in the parser question.

Is there anything you'd like reviewers to focus on?

Nothing in particular!

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 20, 2020
@kaicataldo kaicataldo added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Aug 20, 2020
Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdjermanovic mdjermanovic merged commit f954476 into master Aug 22, 2020
@mdjermanovic mdjermanovic deleted the kaicataldo-patch-1 branch August 22, 2020 10:17
@mdjermanovic
Copy link
Member

Oops, looks like we missed to update .github/ISSUE_TEMPLATE/BUG_REPORT.md, which is the one that is more often used.

Actually, I'm not sure if there is a scenario where .github/ISSUE_TEMPLATE.md is used?

@yeonjuan
Copy link
Member

yeonjuan commented Aug 22, 2020

@mdjermanovic I think we should update .github/ISSUE_TEMPLATE/BUG_REPORT.md I'll make a new PR for it.

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 18, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants