Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: add es2021 environment (refs #13602) #13603

Merged
merged 2 commits into from Aug 29, 2020
Merged

Update: add es2021 environment (refs #13602) #13603

merged 2 commits into from Aug 29, 2020

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Aug 21, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Add something to the core

refs #13602

What changes did you make? (Give an overview)

  • Added new es2021 environment with FinalizationRegistry and WeakRef globals. edit: this is in @eslint/eslintrc now.
  • Updated --init to enable the new environment in created configs.
  • Updated configuring.md with the new environment.
  • Also updated configuring.md and types.js with ecmaVersion: 2021. edit: done in Upgrade: espree@7.3.0 (refs #13568) #13609
  • Also updated some tests where it seemed the intention was to use the latest es environment and/or the latest ecmaVersion. If that wasn't the case, I can revert those changes.

Is there anything you'd like reviewers to focus on?

  • package.json has github espree reference.
  • Noticed while rebasing at the end that this PR changes some files @nzakas just marked as "do not modify".

@mdjermanovic mdjermanovic added enhancement This change enhances an existing feature of ESLint core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion do not merge This pull request should not be merged yet new syntax This issue is related to new syntax that has reached stage 4 labels Aug 21, 2020
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is okay; I can re-sync to pull these into my work. We just can’t keep making changes on config-related files because I’ll never be able to keep up.

@mdjermanovic
Copy link
Member Author

Rebased to update package.json and undo some changes that were also made in #13609. Also added one no-undef test that might be useful since we don't have specific tests for environments.

@mdjermanovic mdjermanovic removed the do not merge This pull request should not be merged yet label Aug 24, 2020
@mdjermanovic mdjermanovic mentioned this pull request Aug 24, 2020
4 tasks
@mdjermanovic
Copy link
Member Author

Rebased again to fix merge conflicts. In particular, to undo changes in conf/environments.js since that file isn't in this package anymore.

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit 88a9ade into master Aug 29, 2020
@kaicataldo kaicataldo deleted the es2021 branch August 29, 2020 00:36
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 18, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint new syntax This issue is related to new syntax that has reached stage 4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants