Docs: fix examples in object-curly-newline #13605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
soobing
force-pushed
the
docs/object-curly-newline-consistent
branch
from
a3567ba
to
d9c6315
Compare
mdjermanovic
added
accepted
|
Hi @soobing, thanks for the PR! Makes sense to me, marked as accepted. It's usually good to have matching examples in "correct" and "incorrect" sections, though it isn't always possible. Also, it seems we had some wrong examples. |
mdjermanovic
requested changes
Aug 22, 2020
mdjermanovic
changed the title
|
@mdjermanovic |
|
Looks great! Can you please fix the linting error: it seems there's a tab at the beginning of line You can check this locally with |
|
@mdjermanovic |
|
Thanks for contributing! |
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
The example of correct/incorrect really helpful to user.
So if not match between these two, can give confusion.
When I was reading in
object-curly-newlinedocs there was not matching example in case ofconsistent.Is there anything you'd like reviewers to focus on?
I'm not sure that I correctly added example in correct case. So I ask to review to focus on pair between correct case and incorrect case.