Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add 3rd party parsers in BUG_REPORT template #13606

Merged
merged 2 commits into from Aug 22, 2020
Merged

Conversation

yeonjuan
Copy link
Member

@yeonjuan yeonjuan commented Aug 22, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

I thinks we should update .github/ISSUE_TEMPLATE/BUG_REPORT.md rather than .github/ISSUE_TEMPLATE.md.

Is there anything you'd like reviewers to focus on?

Maybe can we remove .github/ISSUE_TEMPLATE.md?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 22, 2020
@yeonjuan yeonjuan changed the title Chore: add 3rd party parsers BUG_REPORT issue template Chore: add 3rd party parsers in BUG_REPORT issue template Aug 22, 2020
@yeonjuan yeonjuan added the chore This change is not user-facing label Aug 22, 2020
@yeonjuan yeonjuan removed the triage An ESLint team member will look at this issue soon label Aug 22, 2020
@mdjermanovic
Copy link
Member

There's also templates/bug-report.md.

This template is linked from the PR template, and meant to be pasted into PR and filled out if the PR doesn't reference an issue.

@yeonjuan yeonjuan changed the title Chore: add 3rd party parsers in BUG_REPORT issue template Chore: add 3rd party parsers in BUG_REPORT template Aug 22, 2020
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit bdb65ec into master Aug 22, 2020
@kaicataldo kaicataldo deleted the yeonjuan-patch-1 branch August 22, 2020 19:55
@kaicataldo
Copy link
Member

Thanks for contributing!

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 18, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants