Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: espree@7.3.0 (refs #13568) #13609

Merged
merged 3 commits into from Aug 24, 2020
Merged

Upgrade: espree@7.3.0 (refs #13568) #13609

merged 3 commits into from Aug 24, 2020

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Aug 22, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Dependency upgrade

refs #13568

What changes did you make? (Give an overview)

As discussed, this PR bumps Espree to include the new ES 2021 language features. Since this environment didn't exist before, I don't think there's much danger in merging this early (even if we don't get the requisite rule changes into the release). That being said, it would be great if we could land it all at once!

cc @anikethsaha @mdjermanovic since you two are working on the core updates :)

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 22, 2020
@kaicataldo kaicataldo added upgrade This change is related to a dependency upgrade and removed triage An ESLint team member will look at this issue soon labels Aug 22, 2020
@kaicataldo kaicataldo changed the title Espree7.3.0 Upgrade: espree@7.3.0 Aug 22, 2020
@kaicataldo kaicataldo changed the title Upgrade: espree@7.3.0 Upgrade: espree@7.3.0 (refs #13568) Aug 22, 2020
@mdjermanovic
Copy link
Member

mdjermanovic commented Aug 22, 2020

lib/shared/types.js Outdated Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nzakas nzakas merged commit 091e52a into master Aug 24, 2020
@nzakas nzakas deleted the espree7.3.0 branch August 24, 2020 17:59
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 18, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion upgrade This change is related to a dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants