Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix typo and missing article before noun in docs #13611

Merged
merged 2 commits into from Aug 25, 2020
Merged

Docs: Fix typo and missing article before noun in docs #13611

merged 2 commits into from Aug 25, 2020

Conversation

pmsandhu
Copy link
Contributor

…lons.

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fixed a typo in the developer-guide/working-with-rules#providing-suggestions documentation - changed semicolumns to semicolons.

Is there anything you'd like reviewers to focus on?

@jsf-clabot
Copy link

jsf-clabot commented Aug 23, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 23, 2020
@pmsandhu pmsandhu changed the title fix type in providing suggestions docs - change semicolumns to semico… fix typo in the providing suggestions docs - changed semicolumns to semico… Aug 23, 2020
@pmsandhu pmsandhu changed the title fix typo in the providing suggestions docs - changed semicolumns to semico… fix type in providing suggestions docs - change semicolumns to semicolons Aug 23, 2020
@pmsandhu pmsandhu changed the title fix type in providing suggestions docs - change semicolumns to semicolons fix typo in providing suggestions docs - change semicolumns to semicolons Aug 23, 2020
@pmsandhu pmsandhu changed the title fix typo in providing suggestions docs - change semicolumns to semicolons Docs: fix typo in providing suggestions docs - change semicolumns to semicolons Aug 23, 2020
@yeonjuan yeonjuan added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Aug 23, 2020
@yeonjuan
Copy link
Member

yeonjuan commented Aug 23, 2020 •
edited

@pmsandhu Thanks!. It looks like you haven't yet signed the CLA. Could you please sign the CLA ?

@pmsandhu
Copy link
Contributor Author

@yeonjuan When I click on the license agreement it says You have signed the CLA for eslint/eslint and all of the fields are disabled. Attached an image below.

CLA_eslint

@yeonjuan
Copy link
Member

@pmsandhu
I'm not sure. But it seems your commit's author is unrecognized. Could you try this ?

@pmsandhu
Copy link
Contributor Author

@yeonjuan yes those are the steps that I followed to sign the CLA. I haven't used github in a while since my company uses gitlab but in gitlab you can rerun a ci/cd step in the plan. Maybe rerunning the licence/cla step again would resolve it, if the ci/cd pipeline is similar to gitlab. Could be completely wrong about that but that is how gitlab works.

@anikethsaha anikethsaha reopened this Aug 23, 2020
@pmsandhu pmsandhu changed the title Docs: fix typo in providing suggestions docs - change semicolumns to semicolons Docs: Fix typo and missing article before noun in docs Aug 23, 2020
@pmsandhu
Copy link
Contributor Author

pmsandhu commented Aug 23, 2020 •
edited

@yeonjuan Reread the link you sent and realized that my git email was set to my work email and not my personal email so that is why the commit author was not recognized. In order to link this pr with the correct email I added another minor documentation fix to the Node.js API - CLIEngine#executeOnFiles() section where the article an was missing before the word array.

@anikethsaha anikethsaha added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 24, 2020
yeonjuan
yeonjuan approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks :)

mdjermanovic
mdjermanovic approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 4111d21 into eslint:master Aug 25, 2020
@mdjermanovic
Copy link
Member

Thanks for contributing!

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 18, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anikethsaha anikethsaha anikethsaha approved these changes

@yeonjuan yeonjuan yeonjuan approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pmsandhu @jsf-clabot @yeonjuan @mdjermanovic @anikethsaha