Update: support logical assignments in code path analysis (refs #13569) #13612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
added
core
mdjermanovic
force-pushed
the
logicalassignment-codepathanalysis
branch
from
6bc7657
to
faa0094
Compare
12 tasks
mdjermanovic
changed the title
1 task
btmills
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
Looks good as far as I can tell based on the dot graphs, though as with most things code path-related, I'd feel better if @mysticatea had a chance to take a look.
Good catch on the (a && b) ?? c issue. Since that's a pre-existing bug, I agree with leaving it alone in this PR 👍
mysticatea
approved these changes
Aug 28, 2020
kaicataldo
approved these changes
Aug 31, 2020
|
Thanks for working on this! |
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Add something to the core
refs #13569
Adds support for logical assignments in code path analysis.
What changes did you make? (Give an overview)
Updated code path analysis to account for short-circuiting semantics of logical assignments.
Is there anything you'd like reviewers to focus on?
(a &&= b) ?? cworks in line with how(a && b) ?? calready works, but I think(a && b) ?? cisn't entirely correct (#13614).