Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove stale Keybase 2FA instructions #13622

Merged
merged 1 commit into from Aug 27, 2020

Conversation

btmills
Copy link
Member

@btmills btmills commented Aug 27, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I deleted docs that referenced an old 2FA flow based on Keybase, which we no longer use.

Is there anything you'd like reviewers to focus on?

Based on a comment by @nzakas, I chose to delete these rather than update them.

Once the bot has successfully posted a release issue using the new template, I also want to update the release instructions on the website to make them consistent, but I think that's best left for a separate pull request.

@btmills btmills added documentation Relates to ESLint's documentation evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 27, 2020
@kaicataldo kaicataldo merged commit 1c35d57 into master Aug 27, 2020
@kaicataldo kaicataldo deleted the remove-keybase-2fa-instructions branch August 27, 2020 17:41
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 18, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants