Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: @eslint/eslintrc to fix rule schema validation (fixes #13793) #13794

Merged
merged 2 commits into from Oct 27, 2020

Conversation

btmills
Copy link
Member

@btmills btmills commented Oct 26, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The bulk of our tests for rule schemas are isolated unit tests of ConfigValidator. This is a single test to be sure we actually run rule schema validation end-to-end and prevent cases like #13793.

Is there anything you'd like reviewers to focus on?

Here's my checklist for the patch release tomorrow. Am I missing anything?

  • Merge Fix: validate schema for built-in rules eslintrc#14.
  • Run a patch release of @eslint/eslintrc.
  • Push a commit to this branch to bump the @eslint/eslintrc dependency to v0.2.1.
  • Remove the "blocked" label.
  • Rename the pull request to title to "Fix" and "fixes".
  • Merge this.
  • Merge any other patch release fixes.
  • Run a patch release of eslint.

The bulk of our tests for rule schemas are isolated unit tests of
`ConfigValidator`. This is a single test to be sure we actually run rule
schema validation end-to-end and prevent cases like #13793.

After I run a patch release of `@eslint/eslintrc`, I'll push a second
commit on this branch to bump the dependency version and fix the test.
@btmills btmills added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion blocked This change can't be completed until another issue is resolved regression Something broke patch candidate This issue may necessitate a patch release in the next few days labels Oct 26, 2020
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test and the plan LGTM!

@btmills btmills removed the blocked This change can't be completed until another issue is resolved label Oct 27, 2020
@btmills btmills changed the title Chore: Test missing built-in rule validation (refs #13793) Upgrade: @eslint/eslintrc to fix rule schema validation (fixes #13793) Oct 27, 2020
@btmills btmills merged commit 08f33e8 into master Oct 27, 2020
@btmills btmills deleted the issue13793 branch October 27, 2020 03:19
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Apr 26, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features patch candidate This issue may necessitate a patch release in the next few days regression Something broke
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants