Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--debug doesn't show debug info from @eslint/eslintrc #13850

Closed
mdjermanovic opened this issue Nov 16, 2020 · 1 comment · Fixed by #13861
Closed

--debug doesn't show debug info from @eslint/eslintrc #13850

mdjermanovic opened this issue Nov 16, 2020 · 1 comment · Fixed by #13861
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint

Comments

@mdjermanovic
Copy link
Member

mdjermanovic commented Nov 16, 2020 •
edited

The version of ESLint you are using.

7.13.0

The problem you want to solve.

eslint --debug doesn't show debug info from @eslint/eslintrc, ref #13848.

Namely, eslintrc:cascading-config-array-factory and eslintrc:config-array-factory.

This info used to be printed when the modules were in eslint/eslint.

Your take on the correct solution to problem.

Either change these to eslint: in eslint/eslintrc, or add eslintrc:* here:

eslint/bin/eslint.js

Line 17 in 37a06d6

require("debug").enable("eslint:*,-eslint:code-path");

Are you willing to submit a pull request to implement this change?

Yes.
@mdjermanovic mdjermanovic added enhancement This change enhances an existing feature of ESLint core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion bug ESLint is working incorrectly labels Nov 16, 2020
@nzakas nzakas added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Nov 17, 2020
@nzakas
Copy link
Member

nzakas commented Nov 17, 2020

Makes sense. I think the right approach is to update the code in bin/eslint.js to include eslintrc:*.

mdjermanovic added a commit that referenced this issue Nov 18, 2020
@mdjermanovic
Fix: enable debug logs for @eslint/eslintrc (fixes #13850)
05f21ed
@mdjermanovic mdjermanovic mentioned this issue Nov 18, 2020
Merged
1 task
mdjermanovic added a commit that referenced this issue Nov 19, 2020
@mdjermanovic
Fix: enable debug logs for @eslint/eslintrc (fixes #13850) (#13861)
2004b7e
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 19, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: enable debug logs for @eslint/eslintrc (fixes #13850) eslint/eslint
2 participants
@nzakas @mdjermanovic