Fix: one-var shouldn't split declaration if it isn't in a statement list #13959
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Tell us about your environment
What parser (default,
@babel/eslint-parser
,@typescript-eslint/parser
, etc.) are you using?default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
Online Demo
What did you expect to happen?
Given that this rule already reports errors that require non-trivial manual fixes, I'd expect an error without the autofix. This code can be fixed by adding a block (or in some other way), but that seems out of scope for this rule.
What actually happened? Please include the actual, raw output from ESLint.
Error with autofix that produces a syntax error:
What changes did you make? (Give an overview)
Fixed
splitDeclarations()
to produce a fix only if the givenVariableDeclaration
is in a statement list, i.e. if it is a child ofProgram
,BlockStatement
, orSwitchCase
node.Autofix will not be provided if the reported declaration is a direct child of
if
,while
,do-while
,for
,for-in
,for-of
orwith
, or if it is labeled.Is there anything you'd like reviewers to focus on?
There's also a false negative in
SwitchCase
nodes when the option is"consecutive"
(I'll fix that in another PR), and inconsistent behavior withexport
-ed declarations (I'll open an issue for that).