Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update semantic versioning policy #13970

Merged
merged 2 commits into from Jan 6, 2021
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Dec 31, 2020

Explicitly mention how we handle new language features for rules.

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Updated the semantic versioning policy per our discussion on 2020-12-31 to explicitly state that rules can add new language features that result in more linting errors by default in a semver-minor release.

Is there anything you'd like reviewers to focus on?

Did I word this addition correctly?

Explicitly mention how we handle new language features for rules.
@nzakas nzakas added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Dec 31, 2020
README.md Outdated Show resolved Hide resolved
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once clarified as "addition".

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit f6948f6 into master Jan 6, 2021
@mdjermanovic mdjermanovic deleted the semver-policy-update branch January 6, 2021 19:28
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jul 6, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants