Fix: nested indenting for offsetTernaryExpressions: true (fixes #13971)

[brodybits]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

resolves #13971

This update applies one more condition for the consequent to avoid extra indenting in a nested ternary expression like this:

condition1
  ? condition2
    ? Promise.resolve(1)
    : Promise.resolve(2)
  : Promise.resolve(3)

Note that the condition was mostly copied from the condition that @sheerun had included for the alternate in PR #12556 (bb6cf50).

Is there anything you'd like reviewers to focus on?

I hope there is enough information in issue #13971 to explain the issue and in this PR to understand the solution. I would be happy to add some more test cases and documentation updates if needed.

This PR can help unblock the following issues and updates in some other projects:

• Ternary indenting issues from eslint standard/standard#1624
• Inconsistent formatting of nested ternary expressions brodybits/prettierx#41
• Weird formatting of long nested ternary expression sheerun/prettier-standard#76
• use nested ternaries in tests ... with some Prettier lint settings NOT WANTED brodybits/react-native-module-init#85

[eslint-deprecated]

Hi @brodybits!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag must be one of the following:

  The Tag is one of the following:

  • Fix - for a bug fix.
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
  • New - implements a new feature.
  • Breaking - for a backwards-incompatible enhancement or feature.
  • Docs - changes to documentation only.
  • Build - changes to build process only.
  • Upgrade - for a dependency upgrade.
  • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

  You can use the labels of the issue you are working on to determine the best tag.

• There should be a space following the initial tag and colon, for example 'New: Message'.

• The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

[sheerun]

looks good :)

[eslint-deprecated]

Hi @brodybits!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

[eslint-deprecated]

Hi @brodybits!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

[brodybits]

I have rebased and updated the title again to fit within the 72 characters, hope it is good to go. I will not likely be active on GitHub for the next 25-30 hours. Thanks!

[btmills]

LGTM, thanks @brodybits! Glad to see this could be fixed with a single condition.

[brodybits]

Much appreciated, this will unblock issues on "Standard JS" and prettier-standard.