Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: space-in-parens examples with no arguments etc. #13987

Merged
merged 1 commit into from Jan 10, 2021
Merged

Docs: space-in-parens examples with no arguments etc. #13987

merged 1 commit into from Jan 10, 2021

Conversation

brodybits
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

add examples such as foo( ) & foo(/* bar */)

What changes did you make? (Give an overview)

Add incorrect & correct examples for space-in-parens:

  • foo( )
  • foo(/* bar */)
  • foo( /* bar */ )

related to: PR #13986 - test foo( ) with space-in-parens: ["error", "always"]

Is there anything you'd like reviewers to focus on?

see above

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 5, 2021
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Jan 6, 2021
@mdjermanovic
Copy link
Member

Thanks for the PR! I think the added examples are very useful to further clarify the behavior with empty parens, and also clarify that parens with comments inside are not treated as empty parens.

mdjermanovic
mdjermanovic approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

btmills
btmills approved these changes Jan 10, 2021
View reviewed changes
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for improving the docs!

@btmills btmills merged commit 4a38bbe into eslint:master Jan 10, 2021
@brodybits brodybits deleted the patch-2 branch February 1, 2021 01:14
@Obi-Dann Obi-Dann mentioned this pull request Apr 10, 2021
Draft
@github-actions github-actions bot mentioned this pull request Apr 12, 2021
Merged
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jul 10, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@btmills btmills btmills approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brodybits @mdjermanovic @btmills