New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: fix comma-dangle schema (fixes #13739) #14030
Conversation
Hi @JoakimoNilsson!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
761cbb6
to
65959be
Compare
Hi @JoakimoNilsson!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
65959be
to
62473df
Compare
Hi @JoakimoNilsson!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
62473df
to
6f0f5fa
Compare
Hi @JoakimoNilsson, thanks for the PR! I converted this to draft to avoid accidental merging, as it's a breaking change so we'll wait for the next major release. |
Thank you @mdjermanovic! If there's anything I can do don't hesitate to ask! |
@JoakimoNilsson the change looks good! Could you please update the commit message to start with It can be like the current PR title: Alternatively, we could change the commit message on merge. |
Let's just update on merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #13739
What changes did you make? (Give an overview)
Added
additionalItems: false
in order to allow specifying only 1 option.Is there anything you'd like reviewers to focus on?
Please see #13166 for discussions regarding semver handling on this (breaking) change. A revert was made on the accepted PR, so this fix is pending a new major release