Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many symbolic links #14151

Closed
bidoubiwa opened this issue Mar 1, 2021 · 2 comments
Closed

Too many symbolic links #14151

bidoubiwa opened this issue Mar 1, 2021 · 2 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects

Comments

@bidoubiwa
Copy link

Tell us about your environment

  • ESLint Version: 7.21
  • Node Version: 12
  • npm Version: 6.14
  • Operating System: Linux

What parser (default, @babel/eslint-parser, @typescript-eslint/parser, etc.) are you using?
default

Please show your full configuration:

Configuration
module.exports = {
  env: {
    browser: true,
    commonjs: true,
    es2020: true,
    node: true
  },
  globals: {
    strapi: true
  },
  extends: [
    'plugin:react/recommended',
    'standard'
  ],
  parserOptions: {
    ecmaFeatures: {
      jsx: true
    },
    ecmaVersion: 11
  },
  plugins: [
    'react'
  ],
  settings: {
    react: {
      version: 'detect'
    }
  },
  rules: {
    'react/jsx-indent': 'error'
  }
}

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

eslint --ext .js .
eslint --ext .js .

What did you expect to happen?
Nothing changed with minor release

What actually happened? Please copy-paste the actual, raw output from ESLint.

Oops! Something went wrong! :(

ESLint: 7.21.0

Error: ELOOP: too many symbolic links encountered, 

Steps to reproduce this issue:

  1. at root, create dir with project
  2. Inside sub-dir inside folder, create symbolic link to root (possible recursion?)
  3. Run linter and get above throw

Are you willing to submit a pull request to fix this bug?
Not sure where the problem lies

@bidoubiwa bidoubiwa added bug ESLint is working incorrectly triage An ESLint team member will look at this issue soon labels Mar 1, 2021
@mdjermanovic mdjermanovic added core Relates to ESLint's core APIs and features and removed triage An ESLint team member will look at this issue soon labels Mar 1, 2021
@mdjermanovic mdjermanovic added this to Needs Triage in Triage via automation Mar 1, 2021
@mdjermanovic mdjermanovic moved this from Needs Triage to Evaluating in Triage Mar 1, 2021
@mdjermanovic
Copy link
Member

Hi @bidoubiwa, thanks for the issue!

The change in behavior is caused by #14126, which fixed #13551 and #13615.

Nothing changed with minor release

Ignoring symbolic links was a bug introduced in ESLint v7, so we decided to restore the intended behavior in a minor release.

Previous versions used to follow symbolic links, and I'm getting the same Error: ELOOP: too many symbolic links encountered with ESLint v6.8.0 if there are circular symlinks.

If you need to have circular links in your project tree, can you ignore them with the ignorePatterns config option or in the .eslintignore file?

@bidoubiwa
Copy link
Author

This fixed my issue thanks a lot :)

Triage automation moved this from Evaluating to Complete Mar 1, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Aug 29, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
Archived in project
Triage
Complete
Development

No branches or pull requests

2 participants