Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: ignore pnpm-lock.yaml #14303

Merged
merged 1 commit into from Apr 9, 2021
Merged

Chore: ignore pnpm-lock.yaml #14303

merged 1 commit into from Apr 9, 2021

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[✅ ] Other, please explain:

What changes did you make? (Give an overview)

Ignore pnpm-lock.yaml for pnpm users. We already ignore package-lock.json and yarn.lock

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Apr 9, 2021
@mdjermanovic mdjermanovic added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Apr 9, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 0c346c8 into eslint:master Apr 9, 2021
@snitin315 snitin315 deleted the chore/ignore-pnpm-lock branch April 10, 2021 00:56
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Oct 7, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants