Fix: create .eslintrc.cjs for module type
#14304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
triage
aladdin-add
reviewed
Apr 17, 2021
aladdin-add
requested changes
Apr 17, 2021
|
I see there is no integration test for the whole workflow of |
|
👍 good to have! |
mdjermanovic
added
accepted
mdjermanovic
requested changes
Apr 19, 2021
|
@aladdin-add @mdjermanovic I have added some test cases. |
btmills
approved these changes
Apr 21, 2021
mdjermanovic
requested changes
Apr 21, 2021
|
@mdjermanovic Thanks for reviewing, I have applied your feedback. Please take a look again. |
|
@mdjermanovic can you take another look at this? |
mdjermanovic
requested changes
May 4, 2021
There was a problem hiding this comment.
@snitin315 sorry for the delay! Looks great, I left some small suggestions about tests.
|
@mdjermanovic All done 🚀 |
mdjermanovic
approved these changes
May 5, 2021
10 tasks
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fixes #14137
Is there anything you'd like reviewers to focus on?
NO