Breaking: Drop codeframe and table formatters
#14316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
triage
Easy upgrades FTW
This was referenced Apr 12, 2021
Merged
mdjermanovic
added
accepted
TimvdLippe
reviewed
Apr 14, 2021
|
ping @fregante — any progress? Would be cool to get this merged 😎 |
|
Sorry for the delay! |
lydell
reviewed
Jun 3, 2021
mdjermanovic
requested changes
Jun 11, 2021
There was a problem hiding this comment.
@fregante can you fix #14316 (comment), and rebase (there's a conflict in package.json)?
Everything else LGTM
nzakas
approved these changes
Jun 17, 2021
|
I see that the 8.0.0 milestone has been created, excited for that! Can we add this PR to the milestone as well? Thanks! |
|
Only issues are in v8.0.0 board. This PR is there by virtue of the linked issue. |
|
Ah of course. Sorry for the noise! |
fregante
added a commit
to eslint-community/eslint-formatter-table
that referenced
this pull request
Aug 3, 2021
|
If anyone wants to maintain these 2 formatters, let me know, they're available as standalone projects:
Please advertise them in your post because I won't be maintaining them. |
This was referenced Aug 5, 2021
1 task
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14277
Related to #14098
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Removal of features. Breaking
What changes did you make? (Give an overview)
I dropped the
tableandcodeframeformatters from the core as discussed in #14277Is there anything you'd like reviewers to focus on?