Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggestions for radix rule #14356

Closed
fisker opened this issue Apr 23, 2021 · 2 comments
Closed

Add suggestions for radix rule #14356

fisker opened this issue Apr 23, 2021 · 2 comments
Assignees
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules triage An ESLint team member will look at this issue soon
Projects

Comments

@fisker
Copy link
Contributor

fisker commented Apr 23, 2021

What rule do you want to change?

Add suggestions for invalid cases.

Does this change cause the rule to produce more or fewer warnings?

No.

How will the change be implemented? (New option, new default behavior, etc.)?

Apply suggestions in editor.

Please provide some example code that this change will affect:

const foo = parseInt("0xff");

// Suggest
const foo = parseInt("0xff", 10);
const foo = parseInt("0xff", 16.5);

// Suggest
const foo = parseInt("0xff", 16);
// and
const foo = parseInt("0xff", 10);

What does the rule currently do for this code?

No suggestions at all.

What will the rule do after it's changed?

Have suggestions.

Are you willing to submit a pull request to implement this change?

Maybe.

@fisker fisker added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules triage An ESLint team member will look at this issue soon labels Apr 23, 2021
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Apr 23, 2021
@aladdin-add
Copy link
Member

there is already an opened PR: #14291

@aladdin-add aladdin-add moved this from Needs Triage to Evaluating in Triage Apr 23, 2021
@aladdin-add aladdin-add self-assigned this Apr 23, 2021
@fisker
Copy link
Contributor Author

fisker commented Apr 23, 2021

Thank you, didn't know that.

@fisker fisker closed this as completed Apr 23, 2021
Triage automation moved this from Evaluating to Complete Apr 23, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Oct 21, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules triage An ESLint team member will look at this issue soon
Projects
Archived in project
Triage
Complete
Development

No branches or pull requests

2 participants