do not call the fix functions in no-autofix mode

[aladdin-add]

The version of ESLint you are using.
latest

The problem you want to solve.

eslint will always call the fix functions even in no-autofix mode.

Your take on the correct solution to problem.

do not call the fix functions in no-autofix mode. Pros:

• avoid crashing in no-autofix mode if there are bugs in the fixers. e.g., Crash with "arrow-body-style": ["error", "always"] #14633
• Perf improvement in no-autofix mode.

[mdjermanovic]

Running ESLint in no-autofix mode doesn't necessarily mean that fixes are not needed. Autofix mode (--fix) is more like "automatically apply fixes". Integrations can use LintMessage#fix property to manually apply fixes (vscode-eslint example). I think that without an additional flag we can't really know whether or not the fix property will be used.

[aladdin-add]

good point! but at the very least, it can be skipped in eslint cli. :)

[mdjermanovic]

but at the very least, it can be skipped in eslint cli. :)

Integrations/scripts can run ESLint through cli (ale example) and then use the output from a formatter, so we can't be sure that fix isn't needed (e.g., json formatter prints fix). I think this would be likely a breaking change, and that we'd also need to add a cli flag that could restore the previous behavior.

[nzakas]

I’m not sure this is worth changing without quantifying what kind of performance change we might get.

@aladdin-add if you’re interested in pursuing this, I’d suggest creating a perf test that shows the difference between what we have now and what you’re suggesting. I’m guessing the actual change is probably pretty small.

[nzakas]

Closing because we couldn’t reach consensus on moving forward here.