New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Exit on fatal error (fixes #13711) #14730
Conversation
Hi @A-Katopodis!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good start. I left a few suggestions. I think if you rebase on top of master then you’ll fix the linting errors in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@A-Katopodis we'd like to thank you for your work on this PR. Can you shoot me an email at contact (at) eslint (dot) org? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left just some small suggestions about documentation and test descriptions.
@A-Katopodis can you take a look at the latest review comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Created a new feature which enables ESLint to exit with code 2 instead of 1 when there are any fatal errors. More on this feature can be found in the RFC.
Is there anything you'd like reviewers to focus on?
The unit test coverage remained the same. The docs where updated as well but the only appropriate change or place to mention the new argument I found was in
command-line-interface.md
. Let me know if there are places I missed.