New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for #x in obj
private-in syntax
#14811
Comments
The ESTree syntax is effectively done, just waiting for one last 👍. Next we are blocked on Acorn |
#x in obj
syntax#x in obj
private-in syntax
I tried the rules of ESLint using acorn which built the source in github repo. But I couldn't find the rule that needed to be changed. |
With /* eslint space-unary-ops: ["error", { "words": false }] */
class C {
#x;
*foo(bar) {
yield #x in bar;
}
} These are very edge cases, though. |
It looks like we are just on the last step here? |
Espree needs to update Acorn version. Acorn hasn't released this change yet (v8.5.0 includes class static blocks, but not this syntax). |
That's strange, class static blocks have been stage 4 for a week, but class private fields with |
Open source doesn’t follow predictable schedules. :) |
ha, true enough :-) |
Acorn 8.6 is just released and includes the necessary change: https://github.com/acornjs/acorn/releases/tag/8.6.0. |
@mkubilayk Thanks for letting me know! |
The version of ESLint you are using.
7.31.0
The problem you want to solve.
Support Ergonomic brand checks for Private Fields (
#x in obj
syntax) officially, as it has reached stage-4.refs:
https://github.com/tc39/proposals/blob/master/finished-proposals.md
https://github.com/tc39/proposal-private-fields-in-in
Your take on the correct solution to problem.
#x in obj
syntax tc39/ecma262#2290Maybe we just merge https://github.com/estree/estree/blob/master/stage3/private-fields-in-in.md into es2022.md.eslint-visitor-keys
update:Maybe we have no task on it.
espree
update: feat: support for private-in syntax espree#521eslint-scope
update:Maybe we have no task on it.
eslint
update:Are you willing to submit a pull request to implement this change?
It's difficult for me to change the parser.
I may be able to do other necessary work.
The text was updated successfully, but these errors were encountered: