New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: reporting loc for never
option in eol-last
(refs #12334)
#14840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine for "always"
to report only start loc after the code, but for "never"
we could report the linebreak's range (VSCode handles this well by underlining space after the column end) like we are already doing in the linebreak-style
rule. Thoughts?
Makes sense, I will update 👍🏻 |
eol-last
(refs #12334)never
option in eol-last
(refs #12334)
Hi @snitin315!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
never
option in eol-last
(refs #12334)never
option in eol-last
(refs #12334)
Hi @snitin315!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
never
option in eol-last
(refs #12334)never
option in eol-last
(refs #12334)
ce90dc0
to
3ddb815
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Other, please explain:
What changes did you make? (Give an overview)
Refs #12334
Add assertions on reporting location in test cases for
eol-last
.Is there anything you'd like reviewers to focus on?
No