Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rules to support ES2022 class fields #14857

Closed
32 tasks done
btmills opened this issue Jul 30, 2021 · 27 comments
Closed
32 tasks done

Update rules to support ES2022 class fields #14857

btmills opened this issue Jul 30, 2021 · 27 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint new syntax This issue is related to new syntax that has reached stage 4 rule Relates to ESLint's core rules
Projects
v8.0.0 Triage

Comments

@btmills
Copy link
Member

btmills commented Jul 30, 2021 •
edited by mdjermanovic

What is the name of the syntax to implement?

Class fields

Please provide the TC39 URL for the syntax proposal:

Implementation Checklist

This issue tracks rules that need to be updated to support ES2022 class fields. Please add to this list if there are any additional rules that need to be updated. I've linked to any comments on the original PR for easier reference. Some rule updates may have been finished in #14591, in which case we can confirm the updates are sufficient and check off the rule here.

Are you willing to submit a pull request to implement this syntax?

We can work on these in parallel. To avoid redundant effort, please claim a rule when you start working on it.
@btmills btmills added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules new syntax This issue is related to new syntax that has reached stage 4 labels Jul 30, 2021
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Jul 30, 2021
@btmills btmills moved this from Needs Triage to Ready to Implement in Triage Jul 30, 2021
@btmills btmills added this to Planned in v8.0.0 Jul 30, 2021
@mdjermanovic
Copy link
Member

Working on prefer-destructuring

mdjermanovic added a commit that referenced this issue Aug 6, 2021
@mdjermanovic
Fix: prefer-destructuring PrivateIdentifier false positive (refs #14857)
9fae014
@mdjermanovic mdjermanovic mentioned this issue Aug 6, 2021
Merged
1 task
@mdjermanovic
Copy link
Member

mdjermanovic commented Aug 6, 2021 •
edited

Checked off rules that already look good: computed-property-spacing, no-eval, no-extra-semi, no-invalid-this, no-self-assign, prefer-exponentiation-operator, quotes, semi-spacing, semi-style, space-infix-ops.

@mdjermanovic
Copy link
Member

Working on dot-notation.

mdjermanovic added a commit that referenced this issue Aug 6, 2021
@mdjermanovic
Fix: dot-notation false positive with private identifier (refs #14857)
01b302d
@mdjermanovic mdjermanovic mentioned this issue Aug 6, 2021
Merged
1 task
@snitin315
Copy link
Contributor

working on keyword-spacing

@mdjermanovic
Copy link
Member

Working on no-useless-computed-key.

mdjermanovic added a commit that referenced this issue Aug 8, 2021
@mdjermanovic
Fix: no-useless-computed-key edge cases with class fields (refs #14857)
317a069
@mdjermanovic mdjermanovic mentioned this issue Aug 8, 2021
Merged
1 task
@mdjermanovic
Copy link
Member

Working on no-extra-parens.

mdjermanovic added a commit that referenced this issue Aug 8, 2021
@mdjermanovic
Update: check class fields in no-extra-parens (refs #14857)
fd3e8c2
@mdjermanovic mdjermanovic mentioned this issue Aug 8, 2021
Merged
1 task
@mdjermanovic
Copy link
Member

Working on no-multi-assign (it's a documentation-only issue).

mdjermanovic added a commit that referenced this issue Aug 8, 2021
@mdjermanovic
Docs: add class fields in no-multi-assign documentation (refs #14857)
81816f9
@mdjermanovic mdjermanovic mentioned this issue Aug 8, 2021
Merged
1 task
@mdjermanovic
Copy link
Member

mdjermanovic commented Aug 8, 2021 •
edited

Working on func-names (it's a documentation-only issue).

mdjermanovic added a commit that referenced this issue Aug 8, 2021
@mdjermanovic
Docs: add class fields in func-names documentation (refs #14857)
a3f17d2
@mdjermanovic mdjermanovic mentioned this issue Aug 8, 2021
Merged
1 task
nzakas pushed a commit that referenced this issue Aug 9, 2021
@mdjermanovic
Docs: add class fields in func-names documentation (refs #14857) (#14908
d234d89 
)
nzakas pushed a commit that referenced this issue Aug 9, 2021
@mdjermanovic
Docs: add class fields in no-multi-assign documentation (refs #14857) (…
5c3a470 
…#14907)
nzakas pushed a commit that referenced this issue Aug 9, 2021
@mdjermanovic
Update: check class fields in no-extra-parens (refs #14857) (#14906)
9052eee
nzakas pushed a commit that referenced this issue Aug 10, 2021
@mdjermanovic
Fix: dot-notation false positive with private identifier (refs #14857) (
ccb9a91 
#14898)

* Fix: dot-notation false positive with private identifier (refs #14857)

* Add example in docs
@mdjermanovic
Copy link
Member

@eslint/eslint-tsc thoughts about #14591 (comment) - should the no-undef-init rule apply to class fields by default, or behind an option, or not at all?

Currently, as implemented in #14591, it applies to class fields by default. If that's the desired behavior, we should fix a bug (#14591 (comment)) and update the docs to complete the task since the documentation for this rule says that it targets variables.

I'm leaning toward making a separate rule so that users can enable/disable them separately. The new rule would also emphasize the fact that class field definition always creates a property, even if the initial value is not specified. It wouldn't be a blocker for v8.0.0, the task for v8.0.0 would be just to revert the change made in #14591.

mdjermanovic added a commit that referenced this issue Aug 27, 2021
@mdjermanovic
Update: support class fields in the complexity rule (refs #14857)
05038f3
@nzakas
Copy link
Member

nzakas commented Aug 27, 2021

@mdjermanovic I think no-undef-init should not apply to class fields. If we do anything, I think a separate rule would make sense, though I'm not sure it's important enough to warrant a core rule. I'll defer to consensus on that.

@btmills
Copy link
Member Author

btmills commented Aug 29, 2021

I could make a case either way for no-undef-init applying to class fields with an option or as a separate rule, so I’ll defer to consensus in favor of leaving it for a separate rule.

@mdjermanovic
Copy link
Member

Working on no-undef-init

mdjermanovic added a commit that referenced this issue Aug 30, 2021
@mdjermanovic
Fix: no-undef-init should not apply to class fields (refs #14857)
742ac06
@mdjermanovic mdjermanovic mentioned this issue Aug 30, 2021
Merged
1 task
@mdjermanovic
Copy link
Member

#14994 fixes #14591 (comment) as agreed (no-undef-init should not apply to class fields), so #14591 (comment) no longer applies.

@yeonjuan
Copy link
Member

Working on class-methods-use-this

mdjermanovic added a commit that referenced this issue Aug 31, 2021
@mdjermanovic
Docs: add no-dupe-class-members examples with class fields (refs #14857)
b72b3dc
@mdjermanovic mdjermanovic mentioned this issue Aug 31, 2021
Merged
1 task
@mdjermanovic
Copy link
Member

Prepared #15005 to update documentation for no-dupe-class-members.

Regarding #14591 (comment), we discussed that question in #14979 and decided to not make any changes for now.

yeonjuan added a commit that referenced this issue Sep 1, 2021
@yeonjuan
Update: update options in class-methods-use (refs #14857)
d37fa5a
nzakas pushed a commit that referenced this issue Sep 2, 2021
@mdjermanovic
Docs: add no-dupe-class-members examples with class fields (refs #14857…
4338b74 
…) (#15005)
mdjermanovic added a commit that referenced this issue Sep 2, 2021
@mdjermanovic
Fix: no-undef-init should not apply to class fields (refs #14857) (#1…
e9764f3 
…4994)

* Fix: no-undef-init should not apply to class fields (refs #14857)

* update docs
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Sep 5, 2021
mdjermanovic pushed a commit that referenced this issue Sep 5, 2021
@nzakas
Fix: Update semi for class-fields (refs #14857) (#14945)
f966fe6 
* Fix: Update semi for class-fields (refs #14591)

* Fixed several bugs

* Ensure beforeStatementContinuationChars does not apply to class fields

* Fix semi rule bugs for class fields

* Fix edge cases
@mdjermanovic
Copy link
Member

Working on lines-between-class-members

mdjermanovic added a commit that referenced this issue Sep 9, 2021
@mdjermanovic
Fix: semicolon-less style in lines-between-class-members (refs #14857)
48271ab
@mdjermanovic mdjermanovic mentioned this issue Sep 9, 2021
Merged
1 task
mdjermanovic added a commit that referenced this issue Sep 10, 2021
@yeonjuan @mdjermanovic
Update: enforceForClassFields in class-methods-use-this (refs #14857) (…
6d1ccb6 
…#15018)

* Update: update options in class-methods-use (refs #14857)

* fix default option

* fix review

* fix

* remove unnecessary listener

* Update docs/rules/class-methods-use-this.md

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

* Update docs/rules/class-methods-use-this.md

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

* Update docs/rules/class-methods-use-this.md

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

* Update docs/rules/class-methods-use-this.md

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

* Update docs/rules/class-methods-use-this.md

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

* Update docs/rules/class-methods-use-this.md

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

* Update docs/rules/class-methods-use-this.md

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

* change example order

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
mdjermanovic added a commit that referenced this issue Sep 10, 2021
@mdjermanovic
Fix: semicolon-less style in lines-between-class-members (refs #14857) (
9bd3d87 
#15045)
mdjermanovic added a commit that referenced this issue Sep 10, 2021
@mdjermanovic
Update: support class fields in the complexity rule (refs #14857) (#…
88a3952 
…14957)

* Update: support class fields in the `complexity` rule (refs #14857)

* Use code path analysis

* Remove an extra empty line
@mdjermanovic
Copy link
Member

All planned tasks are done 🎉

I made a quick pass through all rules to check if anything should be additionally updated because of the new code path and new scope for class field initializers, and I didn't see any problems.

If anyone finds more rules that need to be updated, please open new issues.

Triage automation moved this from Ready to Implement to Complete Sep 10, 2021
v8.0.0 automation moved this from Pull Request Opened to Done Sep 10, 2021
@lorenzos lorenzos mentioned this issue Dec 2, 2021
Closed
1 task
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 10, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint new syntax This issue is related to new syntax that has reached stage 4 rule Relates to ESLint's core rules
Projects
Triage
Archived in project
v8.0.0
  
Done
Triage
Complete
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nzakas @btmills @yeonjuan @mdjermanovic @snitin315