New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: js-yaml
to v4
#14890
Upgrade: js-yaml
to v4
#14890
Conversation
It looks like the licensing check failed:
Links for context about argparse/js-yaml (TLDR: this dependency and the license won't be changing):
Context about licensing in eslint:
So we need to decide if the Python license is acceptable. It looks like the Python license is OSI approved: https://opensource.org/licenses/alphabetical |
Let me ask the OpenJS folks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* master: Chore: Add rel/abs path tests in `no-restricted-{imports/modules}` rules (eslint#14910) Upgrade: Debug 4.0.1 > 4.3.2 (eslint#14892) Chore: add assertions on reporting location in `semi` (eslint#14899) Fix: no-useless-computed-key edge cases with class fields (refs eslint#14857) (eslint#14903) Upgrade: `js-yaml` to v4 (eslint#14890) Fix: prefer-destructuring PrivateIdentifier false positive (refs eslint#14857) (eslint#14897) Fix: dot-notation false positive with private identifier (refs eslint#14857) (eslint#14898) Sponsors: Sync README with website Sponsors: Sync README with website Docs: improve rule details for `no-console` (fixes eslint#14793) (eslint#14901) Update: check class fields in no-extra-parens (refs eslint#14857) (eslint#14906) Docs: add class fields in no-multi-assign documentation (refs eslint#14857) (eslint#14907) Docs: add class fields in func-names documentation (refs eslint#14857) (eslint#14908) Upgrade: `eslint-visitor-keys` to v3 (eslint#14902) Upgrade: `markdownlint` dev dependencies (eslint#14883) Upgrade: @humanwhocodes/config-array to 0.6 (eslint#14891) Chore: Specify Node 14.x for Verify Files CI job (eslint#14896)
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
What changes did you make? (Give an overview)
Updates dependency.
https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md#400---2021-01-03
Also allow Python licenses (OSI approved) for transitive dependency argparse.
Is there anything you'd like reviewers to focus on?
No.