Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add an example Object.assign() for rule no-import-assign #14916

Merged
merged 3 commits into from Aug 12, 2021
Merged

Docs: add an example Object.assign() for rule no-import-assign #14916

merged 3 commits into from Aug 12, 2021

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Aug 11, 2021 •
edited

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

as #14911 (comment), it has been supported but not documented.

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Aug 11, 2021
@aladdin-add aladdin-add added documentation Relates to ESLint's documentation enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Aug 11, 2021
aladdin-add and others added 2 commits August 11, 2021 10:55
@aladdin-add @snitin315
Update docs/rules/no-import-assign.md
6cede70 
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
@aladdin-add @snitin315
Update docs/rules/no-import-assign.md
633c828 
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
snitin315
snitin315 approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion rule Relates to ESLint's core rules and removed enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 11, 2021
mdjermanovic
mdjermanovic approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 1f5d088 into master Aug 12, 2021
@aladdin-add aladdin-add deleted the aladdin-add-patch-2 branch August 12, 2021 02:54
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 9, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aladdin-add @mdjermanovic @snitin315