New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Remove Node 16 CI prerelease workaround (refs #14933) #14935
Conversation
f762b28
to
6807fe2
Compare
We no longer need |
This reverts the change from #14933 now that all peer dependencies are valid with ESLint v8.0.0.
6807fe2
to
bb11577
Compare
Note to whomever merges this: we can also remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I removed |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Remove CI prerelease workaround
What changes did you make? (Give an overview)
Several dev dependencies have a peer dependency on the local ESLint. Prereleases don't satisfy regular version range constraints, so the new peer dependency resolution algorithm in Node 16 rejects
v8.0.0-beta.0
as a valid peer dependency. Until we're done with prereleases, we can use the--force
flag to force npm to accept that the prerelease satisfies the peer dependency.Is there anything you'd like reviewers to focus on?
Once we release
v8.0.0
stable, we can merge this PR. When we do, we should also remove--force
from the build script in Jenkins.