New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update semi for class-fields (refs #14857) #14945
Conversation
In the case that we want /* eslint semi: ["error", "never", { beforeStatementContinuationChars: "never" }] */
class A {
x = y; // false positive
[foo]
} |
Okay, I think I've got the outstanding cases covered. |
We can now remove this: Lines 257 to 259 in d0d46a8
This function is now never used with PropertyDefinition nodes, and this code is wrong (it should have been |
Okay, I think I got everything. Thanks for the eagle-eyed reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fixed the
semi
false positives described in:Is there anything you'd like reviewers to focus on?
Did I miss anything?