Chore: Apply comment require-description and check ClassDeclaration #14949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
require-description
ruleClassDeclaration
(instead of constructor)Is there anything you'd like reviewers to focus on?
In
Makefile.js
, I wasn't clear wheretarget
was coming from, so I wasn't sure how to document that comment.In a few cases, I enabled the "mocha" env over whitelisting specific
it
anddescribe
, as that seemed to capture the intent better, even if it may enable a few other globals.I assumed the few jshint directives, apparently copied from a while ago, could be safely removed.
I've added the "chore" label, even though technically this does impact any users of the
eslint-config-eslint
config (wasn't sure whether it should be treated as "core" either, however).