Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add non-capturing groups info to prefer-named-capture-group (fixes #15007) #15009

Merged
merged 1 commit into from Sep 4, 2021
Merged

Docs: add non-capturing groups info to prefer-named-capture-group (fixes #15007) #15009

merged 1 commit into from Sep 4, 2021
+9 −2

Conversation

akwodkiewicz
Copy link
Contributor

Fixes #15007

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added information about the non-capturing groups to prefer-named-capture-group rule documentation.

Is there anything you'd like reviewers to focus on?

--

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Aug 31, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 31, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Aug 31, 2021
nzakas
nzakas approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. Thanks!

snitin315
snitin315 approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing.

@nzakas nzakas merged commit 8c61f5a into eslint:master Sep 4, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 4, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas approved these changes

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add information about non-capturing regex groups in prefer-named-capture-group docs
4 participants
@akwodkiewicz @nzakas @snitin315 @mdjermanovic