Fix: preserve formatting when rules are removed from disable directives #15081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
refs #14878, fixes #14617 (comment)
This fix aims at preserving the original formatting of eslint-disable-* directives when individual rules are being removed during the autofix.
What changes did you make? (Give an overview)
Extended the removal range for the first and the last element in the rule list.
If the first rule is being removed, the removal range will include all whitespace up to the name of the second rule in the list. This way,
used
will start at the same position whereunused
was.If the last rule is being removed, the removal range will include all whitespace on the left side up to the name of the previous rule in the list. This way,
used
will end at the same position whereunused
was ending, relative to the content that comes after.Is there anything you'd like reviewers to focus on?