feat: Normalize ecmaVersion to eslint-scope when using custom parser #15268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-github-bot
bot
added
the
triage
aladdin-add
reviewed
Nov 7, 2021
aladdin-add
added
core
mdjermanovic
added
accepted
|
What happens when the ecmaVersion is unset? |
|
Analyze the scope as ES5 as before. |
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Add something to the core
Fixes #15256
What changes did you make? (Give an overview)
Change to pass 6 to eslint-scope when ecmaVersion is non number.
This allows the scope to be analyzed as ES6 if the user uses a custom parser and
ecmaVersion: latest.Is there anything you'd like reviewers to focus on?