Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove deprecation note from lines-around-comment #15293

Merged
merged 1 commit into from Nov 12, 2021
Merged

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #15292 by removing the deprecation note from lines-around-comment documentation.

What changes did you make? (Give an overview)

Removed deprecation from the docs for this rule.

Is there anything you'd like reviewers to focus on?

It seems that this was mistakenly added in #14961.

This rule was mistakenly marked as deprecated in the documentation.

Fixes #15292
@mdjermanovic mdjermanovic added bug ESLint is working incorrectly rule Relates to ESLint's core rules documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Nov 11, 2021
@mdjermanovic mdjermanovic removed the bug ESLint is working incorrectly label Nov 11, 2021
@nzakas nzakas merged commit da238cc into main Nov 12, 2021
@nzakas nzakas deleted the issue15292 branch November 12, 2021 01:43
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 12, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: deprecate lines-around-comment
2 participants