feat: update max-depth for class static blocks #15316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Refs #15016, fixes
max-depth
.What changes did you make? (Give an overview)
Updated the
max-depth
rule to treat class static blocks as separate contexts when calculating depth.Before this change:
After this change:
Is there anything you'd like reviewers to focus on?
This is somewhat similar to #15315, but unlike
max-statements
this rule does not report functions. It reports blocks that are nested too deeply, relative to something (program, or function body). I think it makes sense to report blocks inside static blocks, and to calculate depth relative to the top level of static blocks.