feat: update one-var for class static blocks #15317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Refs #15016, fixes
one-var
.What changes did you make? (Give an overview)
This PR fixes false positives of the
one-var
rule with option"always"
where the rule suggests combining declarations from a class static block with declarations from the upper scope.Also enables autofixing declarations at the top level of class static blocks with option
"never"
.Is there anything you'd like reviewers to focus on?
Documentation for this rule states that it applies to functions, but it actually applies everywhere: at the top level, in functions, and in all blocks for block-scoped variables.