Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update eslint-scope for class static blocks #15321

Merged
merged 1 commit into from Nov 17, 2021

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

Refs #15016, fixes eslint-scope.

Updates eslint-scope dependency to v7.0.0, which supports class static blocks.

What changes did you make? (Give an overview)

Updated package.json, updated scope manager documentation, and added no-undef and no-shadow tests with class static blocks.

Is there anything you'd like reviewers to focus on?

Updates `eslint-scope` dependency to v7.0.0, which supports class static blocks.

Refs #15016
@mdjermanovic mdjermanovic added core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion new syntax This issue is related to new syntax that has reached stage 4 labels Nov 16, 2021
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdjermanovic mdjermanovic merged commit 15c1397 into main Nov 17, 2021
@mdjermanovic mdjermanovic deleted the staticblocks-eslintscope branch November 17, 2021 13:13
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 17, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features new syntax This issue is related to new syntax that has reached stage 4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants