Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CLA info #15370

Merged
merged 3 commits into from Dec 8, 2021
Merged

docs: update CLA info #15370

merged 3 commits into from Dec 8, 2021

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Nov 29, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Update CLA info to the latest.

Fix #15367

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Nov 29, 2021
@snitin315 snitin315 added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Nov 29, 2021
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Contributor

@akgupta0777 akgupta0777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed the CLA with the link in the PR. Ready to merge

CONTRIBUTING.md Outdated Show resolved Hide resolved
@mdjermanovic mdjermanovic changed the title docs: udpate CLA info docs: update CLA info Nov 30, 2021
@nzakas
Copy link
Member

nzakas commented Dec 4, 2021

Okay, it looks like EasyCLA doesn’t have a link to directly sign. The best we can do is point people to https://cla.openjsf.org/ which has a copy of the CLA text.

We probably want to change the docs to just say you’ll be asked to sign our CLA when you send your first pull request but you can preview the CLA at this URL.

@snitin315 snitin315 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Dec 4, 2021
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little clean up

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas merged commit 74cf0a0 into main Dec 8, 2021
@nzakas nzakas deleted the docs/update-cla-info branch December 8, 2021 01:48
@piggynl piggynl mentioned this pull request Feb 21, 2022
1 task
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 7, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't able to sign CLA. Links are broken.
4 participants