Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add allowReserved parser option #15387

Merged
merged 2 commits into from Dec 4, 2021
Merged

feat: add allowReserved parser option #15387

merged 2 commits into from Dec 4, 2021

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Fixes #15327

What changes did you make? (Give an overview)

This PR updates Espree dependency to v9.2.0 to include eslint/espree#522, documents the new parser option allowReserved in specifying parser options, and adds a few linter tests for the option.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion feature This change adds a new feature to ESLint upgrade This change is related to a dependency upgrade labels Dec 3, 2021
@mdjermanovic mdjermanovic marked this pull request as draft December 3, 2021 13:59
@mdjermanovic mdjermanovic marked this pull request as ready for review December 4, 2021 00:55
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdjermanovic
Copy link
Member Author

Merging now for the release, I'll add flat config tests in a follow-up PR.

@mdjermanovic mdjermanovic merged commit 5771663 into main Dec 4, 2021
@mdjermanovic mdjermanovic deleted the issue15327 branch December 4, 2021 01:40
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 3, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion feature This change adds a new feature to ESLint upgrade This change is related to a dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Request: provide option to allow parsing specific ES3 reserved words
2 participants