Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use node v16 for macOS and windows jobs #15418

Merged
merged 1 commit into from Dec 14, 2021
Merged

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: CI

What changes did you make? (Give an overview)

Use node v16 for testing on macOS and windows.

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added triage An ESLint team member will look at this issue soon build This change relates to ESLint's build process labels Dec 11, 2021
@snitin315 snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Dec 14, 2021
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. should also move to node v16 in browser test:

node-version: '12'
?

@snitin315
Copy link
Contributor Author

should also move to node v16 in browser test:

We should wait until we use node 16 on Netlify to build the site, this was discussed earlier in #15364 (comment)

@aladdin-add aladdin-add merged commit f2c7ba6 into main Dec 14, 2021
@aladdin-add aladdin-add deleted the ci/use-node-16 branch December 14, 2021 08:24
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 13, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion build This change relates to ESLint's build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants