Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding an incorrect code in for-direction.md #15434

Merged
merged 1 commit into from Dec 17, 2021

Conversation

HolgerJeromin
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update

What changes did you make? (Give an overview)

Added an innocent small bug the rule found in our codebase.

Is there anything you'd like reviewers to focus on?

Feel free to close this PR if you do not agree that this example is interesting.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 17, 2021

CLA Signed

The committers are authorized under a signed CLA.

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Dec 17, 2021
@eslint-github-bot
Copy link

Hi @HolgerJeromin!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Dec 17, 2021
@HolgerJeromin HolgerJeromin changed the title doc: for-direction: Adding an incorrect code docs: Adding an incorrect code in for-direction.md Dec 17, 2021
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Dec 17, 2021
@mdjermanovic
Copy link
Member

Thanks for the PR! It makes sense to add this example because the cause of the bug is a bit different than in other examples.

@mdjermanovic mdjermanovic merged commit 314c84c into eslint:main Dec 17, 2021
@HolgerJeromin HolgerJeromin deleted the patch-1 branch December 17, 2021 23:05
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 16, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants